define-macro: check that ... only follow wildcards
#10
Merged
bennn
merged 1 commits from defmac-ellipses
into master
7 years ago
Loading…
Reference in New Issue
There is no content yet.
Delete Branch 'defmac-ellipses'
Deleting a branch is permanent. It CANNOT be undone. Continue?
One fix for #9
LGTM 🤘
@ -19,2 +34,4 @@
#true))
(module+ test
(require rackunit)
Oops, this comment shoudn't be here
@ -19,2 +34,4 @@
#true))
(module+ test
(require rackunit)
BTW, what is the reason to use
box
andset!-box
to mutateprev-datum
rather than just mutating the variable itself?@ -19,2 +34,4 @@
#true))
(module+ test
(require rackunit)
I'm prejudiced against
set!
. I likebox
to communicate my intentions.But this is your code so you should do what you want.
@ -19,2 +34,4 @@
#true))
(module+ test
(require rackunit)
Oh no, I can’t mess with perfection.
I was just trying to understand what
box
is for. IIUC it’s a way of saving the costs of allocation & GC across function calls by passing what’s essentially a reference to a value rather than the value itself. But, if that’s so, then I don’t understand the benefit of putting a Boolean or symbol in a box, since they’re so tiny to begin with.@ -19,2 +34,4 @@
#true))
(module+ test
(require rackunit)
I think the compiler puts
set!
'd variables into a box (or the moral equivalent of a box). If that's true, then I don't think there's performance savings either way.(This is based on what I remember from talking to Leif)
To me, a box is for saying "this variable is going to be mutated".
8000d41389
.Step 1:
From your project repository, check out a new branch and test the changes.Step 2:
Merge the changes and update on Gitea.