Confusing error for (define-macro (id x ...) ....) #9

When an ellipses follows a non-wildcard variable, define-macro can give a strange error message. E.g.:

#lang racket/base
(require br/define (for-syntax racket/base))

(define-macro (my-begin x ...)
  #'(begin x ...))

Error message:

$ raco make foo.rkt
foo.rkt:5:13: syntax: no pattern variables before ellipsis in template
  at: ...
  in: (begin x ...)

define-macro should warn about ... that don't come after a wildcard (I think that's the only place they're allowed)

When an ellipses follows a non-wildcard variable, `define-macro` can give a strange error message. E.g.: ``` #lang racket/base (require br/define (for-syntax racket/base)) (define-macro (my-begin x ...) #'(begin x ...)) ``` Error message: ``` $ raco make foo.rkt foo.rkt:5:13: syntax: no pattern variables before ellipsis in template at: ... in: (begin x ...) ``` `define-macro` should warn about `...` that don't come after a wildcard (I think that's the only place they're allowed)

Closed by #10

define-macro should warn about ... that don't come after a wildcard (I think that's the only place they're allowed)

They are also allowed after subpatterns like ((X ...) ...) Unfortunately your patch did not handle these correctly.

> `define-macro` should warn about `...` that don't come after a wildcard (I think that's the only place they're allowed) They are also allowed after subpatterns like `((X ...) ...)` Unfortunately your patch did not handle these correctly.

I believe f0ec809502 does what you originally intended.

I believe f0ec809502bb980a97a0fdcf98942f19d9dfc37d does what you originally intended.

Labels Milestones

Confusing error for `(define-macro (id x ...) ....)` #9

Labels Milestones

Confusing error for (define-macro (id x ...) ....) #9

Confusing error for `(define-macro (id x ...) ....)` #9