adjustments

pull/18/head
Matthew Butterick 9 years ago
parent bc95ce269e
commit 63b7f84a89

@ -1,12 +1,36 @@
#lang racket/base #lang racket/base
(require "define.rkt" "coerce/base.rkt" racket/path) (require "define.rkt" "coerce/base.rkt")
;; does path have a certain extension ;; this is identical to `filename-extension` in `racket/path`
;; but will not treat hidden files as an extension (which IMHO is a bug)
(define (filename-extension name)
(let* ([name (file-name-from-path name)]
[name (and name (path->bytes name))])
(cond [(and name (regexp-match #rx#".[.]([^.]+)$" name)) => cadr]
[else #f])))
(module+ test
(require rackunit)
(require (prefix-in rp: racket/path))
(check-equal? (rp:filename-extension (string->path ".foo")) #"foo") ; bad behavior
(check-false (filename-extension (string->path ".foo")))) ; good behavior
;; this is pulled in from `racket/path` to avoid the dependency
(define (file-name-from-path name)
(unless (or (path-string? name)
(path-for-some-system? name))
(raise-argument-error 'file-name-from-path "(or/c path-string? path-for-some-system?)" name))
(let-values ([(base file dir?) (split-path name)])
(and (not dir?) (path-for-some-system? file) file)))
;; does path have a certain extension, case-insensitively
(define+provide+safe (has-ext? x ext) (define+provide+safe (has-ext? x ext)
(pathish? stringish? . -> . boolean?) (pathish? stringish? . -> . boolean?)
(define ext-of-path (filename-extension (->path x))) (define ext-of-path (filename-extension (->path x)))
(->boolean (and ext-of-path (equal? (string-downcase (bytes->string/utf-8 ext-of-path)) (string-downcase (->string ext)))))) (and ext-of-path (equal? (string-downcase (bytes->string/utf-8 ext-of-path)) (string-downcase (->string ext)))))
;; get file extension as a string, or return #f ;; get file extension as a string, or return #f
@ -40,29 +64,27 @@
(define pat (regexp (format "^~a" (regexp-quote starter)))) (define pat (regexp (format "^~a" (regexp-quote starter))))
(and (regexp-match pat str) #t)) (and (regexp-match pat str) #t))
(define (path-hidden? path)
((->string (file-name-from-path path)) . starts-with? . "."))
;; with `remove-ext` and `remove-ext*`,
;; the policy is to pass through hidden files
;; though I can't remember why.
;; take one extension off path ;; take one extension off path
(define+provide+safe (remove-ext x) (define+provide+safe (remove-ext x)
(pathish? . -> . path?) (pathish? . -> . path?)
;; pass through hidden files (those starting with a dot) (let ([path (->path x)])
(let* ([x (->path x)] (if (path-hidden? path)
[x-name (file-name-from-path x)]) path
(if ((->string x-name) . starts-with? . ".") (path-replace-suffix path ""))))
x
(path-replace-suffix x ""))))
;; take all extensions off path ;; take all extensions off path
(define+provide+safe (remove-ext* x) (define+provide+safe (remove-ext* x)
(pathish? . -> . path?) (pathish? . -> . path?)
(define (remove* p) (let loop ([path (->path x)])
(let ([path-with-removed-ext (path-replace-suffix p "")]) (define path-out (remove-ext path))
(if (equal? p path-with-removed-ext) (if (equal? path path-out)
p path
(remove* path-with-removed-ext)))) (loop path-out))))
;; pass through hidden files (those starting with a dot)
(let ([x (->path x)]
[x-name (file-name-from-path x)])
(if ((->string x-name) . starts-with? . ".")
x
(remove* x))))

@ -147,6 +147,7 @@
(check-equal? (get-ext (->path "foo.txt")) "txt") (check-equal? (get-ext (->path "foo.txt")) "txt")
(check-false (get-ext "foo")) (check-false (get-ext "foo"))
(check-false (get-ext ".foo"))
(check-equal? (add-ext (string->path "foo") "txt") (string->path "foo.txt")) (check-equal? (add-ext (string->path "foo") "txt") (string->path "foo.txt"))
(check-equal? (remove-ext foo-path) foo-path) (check-equal? (remove-ext foo-path) foo-path)

Loading…
Cancel
Save