Fix `when/splice' inconsistent return types #131

Closed
leafac wants to merge 1 commits from patch-1 into master
leafac commented 8 years ago (Migrated from github.com)

CURRENT BEHAVIOR

The function when/splice returns either a list (when the condition is true), or a string (when the condition is false). This makes it unusable in contexts that expect lists—for example, (... ,@◊when/splice[...]{...} ...).

EXPECTED BEHAVIOR

The return types of when/splice are consistent. When the condition is false, return an empty list.

**CURRENT BEHAVIOR** The function `when/splice` returns either a list (when the condition is true), or a string (when the condition is false). This makes it unusable in contexts that expect lists—for example, `(... ,@◊when/splice[...]{...} ...)`. **EXPECTED BEHAVIOR** The return types of `when/splice` are consistent. When the condition is false, return an empty list.
leafac commented 8 years ago (Migrated from github.com)

I think I’d need to fix some tests before you can merge this, but before I do that, please let me know if you agree with the change.

I think I’d need to fix some tests before you can merge this, but before I do that, please let me know if you agree with the change.
mbutterick commented 8 years ago (Migrated from github.com)

Closed by 05fad9ba54

Closed by 05fad9ba54694c2279e2d33e588c17b22c2d4c42
This pull request cannot be reopened because the branch was deleted.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b patch-1 master
git pull origin patch-1

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff patch-1
git push origin master
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mbutterick/pollen#131
Loading…
There is no content yet.