Fix make rule parser #28

Merged
markuspf merged 3 commits from fix-make-rule-parser into master 3 years ago
markuspf commented 3 years ago (Migrated from github.com)

There was a bug in the brag expander handling the optional source-name argument to parsers genrated by using make-rule-parser;

No matter what rule-name one gave, the macro just expanded to use PARSE when one gave a source name, hence using the entire grammar, not the sub-grammar given by the rule.

This is an attempt at fixing this bug; includes a regression test.

There was a bug in the brag expander handling the optional `source-name` argument to parsers genrated by using `make-rule-parser`; No matter what rule-name one gave, the macro just expanded to use `PARSE` when one gave a source name, hence using the entire grammar, not the sub-grammar given by the rule. This is an attempt at fixing this bug; includes a regression test.
mbutterick commented 3 years ago (Migrated from github.com)

Thanks!

Thanks!
The pull request has been merged as 6983208426.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b fix-make-rule-parser master
git pull origin fix-make-rule-parser

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff fix-make-rule-parser
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mbutterick/brag#28
Loading…
There is no content yet.