Labels Milestones

Fixes overly tolerant char-set? predicate #5

Merged

tov merged 2 commits from br-char-set-repetition into master 5 years ago

Conversation 1 Commits 2 Files Changed 1

tov commented 5 years ago (Migrated from github.com)

I noticed this bug in Racket's parser-tools/lex, and after submitting a PR for that, I figured brag might suffer from it as well. Indeed, it does. This PR fixes the bug and includes a couple test cases to demonstrate the change.

I noticed this bug in Racket's parser-tools/lex, and after submitting [a PR](https://github.com/racket/parser-tools/pull/10) for that, I figured brag might suffer from it as well. Indeed, it does. This PR fixes the bug and includes a couple test cases to demonstrate the change.

mbutterick commented 5 years ago (Migrated from github.com)

Let’s live dangerously! Thanks.

Let’s live dangerously! Thanks.

👍 1

The pull request has been merged as f8c3f37646.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b br-char-set-repetition master

git pull origin br-char-set-repetition

Step 2:

Merge the changes and update on Gitea.

git checkout master

git merge --no-ff br-char-set-repetition

git push origin master

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels   

bug

  

duplicate

  

enhancement

  

help wanted

  

invalid

  

question

  

wontfix

No Label

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Set Project

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mbutterick/br-parser-tools#5

Write Preview

Loading…

Cancel

Save

There is no content yet.