mbutterick
/
typesetting
2
1
Fork 0
Code Issues 13 Pull Requests Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
quad-break-with-k
quad-break-no-k
hyphenate-v0.2
hyphenate-v0.1
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'fd2708fc28'
${ noResults }
typesetting/pitfall/pdfkit/node_modules/browserify/test/cycle
History
Matthew Butterick 3f36e2ce2c porting 7 years ago
..
mod1 porting 7 years ago
mod2 porting 7 years ago
README.md porting 7 years ago
entry.js porting 7 years ago

README.md

browserify-bug-713

substack/node-browserify#713 breaks resolving an identical module multiple time from different locations when the module has a circular require.

Reproduce

Module requires two copies of the same module (identical apart from path) and the sub module has a circular require.

Example

This is the case with readable-stream. If two different modules depend on the same version readable-stream (and no npm dedupe), then both of those modules are required in the same project, browserify throws a RangeError: Maximum call stack size exceeded

See https://github.com/isaacs/readable-stream/blob/master/lib/_stream_writable.js#L134 and https://github.com/isaacs/readable-stream/blob/master/lib/_stream_duplex.js#L44

This issue is most likely related: substack/node-browserify#735