From 411261849eb2f069736c8bb465447b6ffc01b3a7 Mon Sep 17 00:00:00 2001 From: Matthew Butterick Date: Thu, 2 May 2019 06:58:28 -0700 Subject: [PATCH] bitfield rejects duplicate flag names --- xenomorph/xenomorph/bitfield.rkt | 2 +- xenomorph/xenomorph/test/bitfield-test.rkt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/xenomorph/xenomorph/bitfield.rkt b/xenomorph/xenomorph/bitfield.rkt index cf0c8475..3826da72 100644 --- a/xenomorph/xenomorph/bitfield.rkt +++ b/xenomorph/xenomorph/bitfield.rkt @@ -19,7 +19,7 @@ https://github.com/mbutterick/restructure/blob/master/src/Bitfield.coffee (init-field [(@type type)] [(@flags flags)]) - #;(let ([named-flags (filter values @flags)]) + (let ([named-flags (filter values @flags)]) (unless (= (length named-flags) (length (remove-duplicates named-flags))) (raise-argument-error 'x:bitfield% "no duplicates among flag names" named-flags))) diff --git a/xenomorph/xenomorph/test/bitfield-test.rkt b/xenomorph/xenomorph/test/bitfield-test.rkt index 81a00659..1b54b2cb 100644 --- a/xenomorph/xenomorph/test/bitfield-test.rkt +++ b/xenomorph/xenomorph/test/bitfield-test.rkt @@ -25,7 +25,7 @@ https://github.com/mbutterick/restructure/blob/master/test/Bitfield.coffee "bitfield: should reject too many flags" (check-exn exn:fail? (λ () (x:bitfield uint8 '(Jack Kack Lack Mack Nack Oack Pack Quack Zack Wack))))) -#;(test-case +(test-case "bitfield: should reject duplicate flags" (check-exn exn:fail? (λ () (x:bitfield uint8 '(Jack Jack Jack Jack Jack)))))