Labels Milestones

This fixes sugar and pollen to work with the new expander. I believe that it will work on 6.2 as well. #11

Merged

samth merged 3 commits from fix-new-expander into master 9 years ago

Conversation 6 Commits 3 Files Changed 2

samth commented 9 years ago (Migrated from github.com)

There is no content yet.

mbutterick commented 9 years ago (Migrated from github.com)

Thank you, but Travis says it’s still broken on HEAD —

https://travis-ci.org/mbutterick/sugar/builds/75661137

Thank you, but Travis says it’s still broken on HEAD — https://travis-ci.org/mbutterick/sugar/builds/75661137

mbutterick commented 9 years ago (Migrated from github.com)

(It’s not showing up as an error here because I’ve configured Travis to silence errors on HEAD)

(It’s not showing up as an error here because I’ve configured Travis to silence errors on HEAD)

samth commented 9 years ago (Migrated from github.com)

Ok, I fixed that file's problems as well (plus an unrelated error that now appears on HEAD).

Ok, I fixed that file's problems as well (plus an unrelated error that now appears on HEAD).

samth commented 9 years ago (Migrated from github.com)

And now it works everywhere.

And now it works everywhere.

mbutterick commented 9 years ago (Migrated from github.com)

OK, thank you. To infinity and beyond.

OK, thank you. To infinity and beyond.

mbutterick commented 9 years ago (Migrated from github.com)

Pollen’s going to need some more work to be compatible with the new expander due to non-hygienic (or just sloppy) macrology. But this is a good start, thanks again.

Pollen’s going to [need some more work](https://travis-ci.org/mbutterick/pollen/jobs/75551739) to be compatible with the new expander due to non-hygienic (or just sloppy) macrology. But this is a good start, thanks again.

The pull request has been merged as 984ebf59a1.

You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.

git checkout -b fix-new-expander master

git pull origin fix-new-expander

Step 2:

Merge the changes and update on Gitea.

git checkout master

git merge --no-ff fix-new-expander

git push origin master

Sign in to join this conversation.

Reviewers

Request review

No reviewers

Labels

Apply labels

Clear labels   

bug

  

duplicate

  

enhancement

  

invalid

  

question

  

wontfix

No Label

bug

duplicate

enhancement

invalid

question

wontfix

Milestone

Set milestone

Clear milestone

No items

No Milestone

Projects

Set Project

Clear projects

No project

Assignees

Assign users

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mbutterick/sugar#11

Write Preview

Loading…

Cancel

Save

There is no content yet.