Replace planet requires with local requires of main.rkt. #1

Merged
greghendershott merged 1 commits from master into master 10 years ago
greghendershott commented 10 years ago (Migrated from github.com)

Otherwise this package's implementation would be using the planet
package -- and causing users of this package to download the planet
package -- which doesn't seem right.

Furthermore, my understanding is that it's preferable within a package
to use a relative require -- like (require "main.rkt") -- instead of
requiring the collection itself -- like either of (require describe)
or (require (planet williams/describe/describe)). So even if this were
still a planet package, I think this would be a good change to make.

Otherwise this package's implementation would be using the planet package -- and causing users of this package to download the planet package -- which doesn't seem right. Furthermore, my understanding is that it's preferable within a package to use a relative require -- like `(require "main.rkt")` -- instead of requiring the collection itself -- like either of `(require describe)` or `(require (planet williams/describe/describe))`. So even if this were still a planet package, I think this would be a good change to make.
mbutterick commented 10 years ago (Migrated from github.com)

Good catch. I overlooked that. Thanks.

Good catch. I overlooked that. Thanks.
greghendershott commented 10 years ago (Migrated from github.com)

You're welcome. BTW how I noticed this was from the "fails" message for describe on http://pkgs.racket-lang.org/#

raco setup:  in <pkgs>/describe/describe
/home/racket/build-pkgs/user/.racket/6.1/pkgs/describe/describe/describe-test.rkt:20:9: require: PLaneT could not download the package "williams/describe": tcp-connect: connection failed
  detail: host not found
  address: planet.racket-lang.org
  port number: 80
  step: 1
  system error: Name or service not known; errno=-2
  in: (planet williams/describe/describe)

The failure is apparently just some random TCP error, but the "PLaneT" part caught my eye... wait, what.

You're welcome. BTW how I noticed this was from the "fails" message for `describe` on http://pkgs.racket-lang.org/# ``` raco setup: in <pkgs>/describe/describe /home/racket/build-pkgs/user/.racket/6.1/pkgs/describe/describe/describe-test.rkt:20:9: require: PLaneT could not download the package "williams/describe": tcp-connect: connection failed detail: host not found address: planet.racket-lang.org port number: 80 step: 1 system error: Name or service not known; errno=-2 in: (planet williams/describe/describe) ``` The failure is apparently just some random TCP error, but the "PLaneT" part caught my eye... wait, what.
The pull request has been merged as f84024e944.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b master master
git pull origin master

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff master
git push origin master
Sign in to join this conversation.
No reviewers
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mbutterick/describe#1
Loading…
There is no content yet.